fix(helix-dap): seq number must start at 1 #14706
                
     Merged
            
            
          
      
        
          +5
        
        
          −1
        
        
          
        
      
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Hi there, this is a bit outside of my expertise but I had some issues running the debugger for C projects, due to the following error:
helix_dap::transport [ERROR] err <- DAP session error: expected to not be '0' at (root).seqThe user only sees
Failed to start debug client: server closed the streamit seems like lldb-dap is checking that the sequence number is non-zero:
https://github.com/llvm/llvm-project/blob/main/lldb/tools/lldb-dap/Protocol/ProtocolBase.cpp#L96
The DAP specification says this:
This made me assume that the lldb-dap check is probably correct. In this pull request I added an increment instead of setting the initial value of the request_counter to 1 in order to maintain the semantic meaning of the variable. This change has only been tested with lldb v21.1.3 with C on linux (arch).