feat: determine auto-pairs from injection #14697
Merged
+27
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4rch3n1ng
commented
Oct 30, 2025
m4rch3n1ng
force-pushed
the
injection-auto-pairs
branch
from
c806e75 to
6294bcd
Compare
m4rch3n1ng
force-pushed
the
injection-auto-pairs
branch
from
6294bcd to
6091dc4
Compare
11 tasks
m4rch3n1ng
force-pushed
the
injection-auto-pairs
branch
2 times, most recently
from
f4b58b6 to
ba49f86
Compare
helix-view/src/document.rs
Outdated
| editor: &'a Editor, | ||
| loader: &'a syntax::Loader, | ||
| view: &View, | ||
| doc: &Document, |
Member
There was a problem hiding this comment.
since this is on Document we can use self instead
m4rch3n1ng
force-pushed
the
injection-auto-pairs
branch
from
ba49f86 to
1f3f1b8
Compare
Contributor
Author
|
oh the failing ci is due to updates on the master branch, i was so confused |
Contributor
Author
|
also what did i change to make that fail now? i didn't even touch the typed.rs file?? |
why is this failing? what did i do? i am so confused.
m4rch3n1ng
force-pushed
the
injection-auto-pairs
branch
from
1f3f1b8 to
2a74127
Compare
Member
|
The |
the-mikedavis
approved these changes
Nov 3, 2025
Contributor
Author
yeah did not know, that it did that, but i had the same happen to me over in a different pr like an hour ago. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
similar to #12759, except for auto-pairs instead of comment tokens. unblocks #14696.