4.x: Ensures there is no trailing whitespace in Java properties lines in persistence.adoc with Asciidoctor callouts at the expense of visual cleanliness#9352
Merged
Conversation
… Asciidoctor callouts at the expense of visual cleanliness Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
…P example in persistence.adoc Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
oracle-contributor-agreement
Bot
added
the
OCA Verified
barchetta
reviewed
Oct 9, 2024
…narios Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
barchetta
approved these changes
Oct 10, 2024
barchetta
pushed a commit
to barchetta/helidon
that referenced
this pull request
Oct 11, 2024
… in persistence.adoc with Asciidoctor callouts at the expense of visual cleanliness (helidon-io#9352) * Ensures there is no trailing whitespace in Java properties lines with Asciidoctor callouts at the expense of visual cleanliness Signed-off-by: Laird Nelson <laird.nelson@oracle.com> * Squashable commit; fixes javax.sql.DataSource.main.URL property in UCP example in persistence.adoc Signed-off-by: Laird Nelson <laird.nelson@oracle.com> * Squashable commit; removes more whitespace in Asciidoctor callout scenarios Signed-off-by: Laird Nelson <laird.nelson@oracle.com> --------- Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
barchetta
added a commit
that referenced
this pull request
Oct 11, 2024
… in persistence.adoc with Asciidoctor callouts at the expense of visual cleanliness (#9352) (#9372) * Ensures there is no trailing whitespace in Java properties lines with Asciidoctor callouts at the expense of visual cleanliness --------- Signed-off-by: Laird Nelson <laird.nelson@oracle.com> Co-authored-by: Laird Nelson <laird.nelson@oracle.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the Persistence Guide so that a copy and paste of Java properties excerpts does not include trailing whitespace at the end of the line. (It also corrects a data source property,
url, which should have beenURL. See #9348.)The tradeoff is that the Asciidoctor callout glyph is now smashed up against the end of the line.
Closes #9350.
Closes #9348.