Issue #7230 - JDBC type specific setters based on EclipseLink#7246
Merged
Conversation
oracle-contributor-agreement
Bot
added
the
OCA Verified
Tomas-Kraus
force-pushed
the
issue-7230
branch
2 times, most recently
from
ac254fb to
2945b44
Compare
Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
romain-grecourt
approved these changes
Jul 25, 2023
romain-grecourt
left a comment
romain-grecourt
left a comment
Contributor
There was a problem hiding this comment.
I think we could further improve the setParameter method with switch pattern matching however I think we should wait until IntelliJ adds supports for Java 21.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds type specific setters from EclipseLink DatabasePlatform class.
Added config blueprint for options to customize setters.