4.x: Make check for audience claim in access token optional in OIDC provider#6959
Merged
Conversation
oracle-contributor-agreement
Bot
added
the
OCA Verified
Author
|
Fixed conflict after rebase. |
tomas-langer
requested changes
Jul 24, 2023
Verdent
requested changes
Jul 28, 2023
Verdent
left a comment
Verdent
left a comment
Member
There was a problem hiding this comment.
Right now you are mixing two approaches here. We have tenant and overall OIDC config. I think placing this switch to the BaseBuilder is correct (BaseBuilder is used for both), since audience can be set different for each tenant. But in that case we need to be able also to get it from config in BaseBuilder and not in overall OIDC config only.
added 4 commits
August 17, 2023 12:05
… optional in OIDC provider Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
tomas-langer
changed the title
Verdent
requested changes
Aug 17, 2023
Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
Verdent
approved these changes
Aug 18, 2023
tomas-langer
approved these changes
Aug 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
optional-audienceconfig option to make audience claim optional.Automatic audience claim generation is disabled when this option is set to true.
Resolves #5860