Archetype: add support for conditional blocks #993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tvallin <[email protected]>
oracle-contributor-agreement
bot
added
the
OCA Verified
Contributor
romain-grecourt
left a comment
romain-grecourt
left a comment
There was a problem hiding this comment.
Looks good so far. Few asks:
- Add some negative tests
- Check that when using ClientCompiler / ScriptSerializer empty blocks or blocks with outputs only are removed
Contributor
|
What's the impact on the serialized JSON, I don't see any tests. Given that there is a new block type ; the serialized JSON must be impacted too right ? This means that the javascript interpreter will need to be updated. |
Signed-off-by: tvallin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #747