Skip to content

#307 Assign type of any to asMap and asMappedResults #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

#307 Assign type of any to asMap and asMappedResults #308

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
319026b
Assign type of any to asMap and asMappedResults to allow for assignme…
bbahrman Sep 18, 2024
eed0d5e
Updating to generic type per feedback
bbahrman Sep 19, 2024
f374f77
Removed errant whitepace changes
bbahrman Sep 19, 2024
4477c9a
Updating naming of QueryResultMap back to actual name
bbahrman Oct 22, 2024
2301125
Merge branch '#307-query-result-map' of github.com:bbahrman/typings-s…
bbahrman Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions N/query.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -602,7 +602,10 @@ export interface Condition {
readonly component: Component;
}

export type QueryResultMap = { [fieldId: string]: string | boolean | number | null }
export type QueryMapResult<T> = {
[K in keyof T as Lowercase<K & string>]: string|number|null;
};

/**
* Set of results returned by the query.
*/
Expand Down Expand Up @@ -637,8 +640,7 @@ export interface ResultSet {
* A mapped result is a JavaScript object with key-value pairs.
* In this object, the key is either the field ID or the alias that was used for the corresponding query.Column object.
*/
asMappedResults(): Array<QueryResultMap>;
asMappedResults<QueryResultMap>(): Array<QueryResultMap>;
asMappedResults<T extends QueryMapResult<T>>(): QueryMapResult<T>;
}

/** Corresponds to a single row of the ResultSet. */
Expand All @@ -661,7 +663,6 @@ export interface Result {
* A mapped result is a JavaScript object with key-value pairs.
* In this object, the key is either the field ID or the alias that was used for the corresponding query.Column object.
*/
asMap(): QueryResultMap;
asMap<QueryResultMap>(): QueryResultMap
}

Expand Down