ghcup tui shows docs on ctrl-c

[alanz]

When I am in ghcup tui, I instinctively hit ctrl-c to quit.

And I am always surprised to be taken to a web browser opened to the docs of whatever my cursor is on at the time.

The legend at the bottom does not mention this possibility, perhaps it should, bound to something sane like d

[hasufell]

Changing the key mapping will break lots of users workflows. You can change it yourself:

ghcup-hs/data/config.yaml

Line 33 in d759535

KChar: 'c'

We could also detect control keys and not trigger any of the actions if they are in combination with such.

[alanz]

Ah, so it is looking for the key, regardless of modifiers. Can you make it ignore them if ctrl is pressed at the same time.

Going to the changelog is great, I just have a problem with <ctrl-c> doing it.

[hasufell]

The code is here:

ghcup-hs/app/ghcup/BrickMain.hs

Line 315 in d759535

eventHandler :: BrickState -> BrickEvent String e -> EventM String BrickState ()

PRs welcome.

[hasufell]

The code is here:

ghcup-hs/app/ghcup/BrickMain.hs

Line 315 in d759535

eventHandler :: BrickState -> BrickEvent String e -> EventM String BrickState ()

PRs welcome.

Basically, we're ignoring the modifier: https://hackage.haskell.org/package/vty-5.38/docs/Graphics-Vty-Input-Events.html#t:Event

ghcup-hs/app/ghcup/BrickMain.hs

Lines 328 to 331 in d759535

	(VtyEvent (Vty.EvKey key _)) ->
	case find (\(key', _, _) -> key' == key) (keyHandlers kb) of
	Nothing -> put st
	Just (_, _, handler) -> handler st

Should be something like

    (VtyEvent (Vty.EvKey key [])) ->
      case find (\(key', _, _) -> key' == key) (keyHandlers kb) of
        Nothing -> put st
        Just (_, _, handler) -> handler st

[alanz]

I decided I could live with it when I got

[15 of 15] Compiling Codec.Archive    ( src/Codec/Archive.hs, dist/build/Codec/Archive.o, dist/build/Codec/Archive.dyn_o )

c/archive_random.c:54:13: error:
     error: static declaration of ‘arc4random_buf’ follows non-static declaration
       54 | static void arc4random_buf(void *, size_t);
          |             ^~~~~~~~~~~~~~
   |
54 | static void arc4random_buf(void *, size_t);
   |             ^

In file included from c/archive_random.c:30:0: error: 

/usr/include/stdlib.h:542:13: error:
     note: previous declaration of ‘arc4random_buf’ with type ‘void(void *, size_t)’ {aka ‘void(void *, long unsigned int)’}
      542 | extern void arc4random_buf (void *__buf, size_t __size)
          |             ^~~~~~~~~~~~~~
    |
542 | extern void arc4random_buf (void *__buf, size_t __size)
    |             ^
`gcc' failed in phase `C Compiler'. (Exit code: 1)
Error: cabal: Failed to build libarchive-3.0.3.2 (which is required by
exe:ghcup from ghcup-0.1.19.5). See the build log above for details.

having installed the deps from

ghcup-hs/.github/workflows/bootstrap.yaml

Line 41 in d759535

sudo apt-get install -y libnuma-dev zlib1g-dev libgmp-dev libgmp10 libssl-dev liblzma-dev libbz2-dev git wget lsb-release software-properties-common gnupg2 apt-transport-https gcc autoconf automake build-essential curl gzip

[hasufell]

See vmchale/libarchive#32

[hasufell]

This unfortunately regressed:

ghcup-hs/app/ghcup/BrickMain.hs

Lines 651 to 652 in 456200e

	inner_event@(VtyEvent (Vty.EvKey key _)) ->
	case find (\(key', _, _) -> key' == KeyCombination key []) (keyHandlers kb) of

@lsmor

[lsmor]

I am reviewing it