Skip to content

Conversation

@Dan-Heath
Copy link
Contributor

@Dan-Heath Dan-Heath commented Oct 29, 2025

This PR updates the Boundary KMS docs.

View the update in the preview deployment:

@Dan-Heath Dan-Heath self-assigned this Oct 29, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2025

Vercel Previews Deployed

Name Status Preview Updated (UTC)
Dev Portal ✅ Ready (Inspect) Visit Preview Thu Oct 30 18:28:24 UTC 2025
Unified Docs API ✅ Ready (Inspect) Visit Preview Thu Oct 30 18:22:20 UTC 2025

@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2025

Broken Link Checker

No broken links found! 🎉

@Dan-Heath Dan-Heath marked this pull request as ready for review October 30, 2025 14:42
@Dan-Heath Dan-Heath requested review from a team as code owners October 30, 2025 14:42
This example shows an IBM KMS stanza in the Boundary configuration file:

````hcl
kms "ibmkp" {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikemountain @dkanney I'm a little confused about the naming conventions. Was it intentional to go with ibmkp instead of ibmkms? What convention do other kms's go with?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's how the package is named/exported in the the wrapper itself

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. To maintain consistency, I think we need to rename the header above from

# ibmkms KMS
-->
# ibmkp KMS

cc: @Dan-Heath

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that makes sense. Thanks @moduli ! Just updated it.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, I don't know if that affects anything in docs-nav-data.json?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the navigation pane to reflect the proper product names and make all the KMS provider names consistent. Thanks for thinking that through with me!

@yhyakuna yhyakuna merged commit 56e162e into main Nov 3, 2025
15 checks passed
@yhyakuna yhyakuna deleted the dheath-ibmkp-1 branch November 3, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants