This repository was archived by the owner on Jan 8, 2024. It is now read-only.
Refactor flake and overlay #2555
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thought it was awesome that you guys using nix, so I thought I would help with some minor improvements:
Some non-obvious changes:
Using
packages(or nativeBuildInputs) instead ofbuildInputsfor mkShell allows forXDG_DATA_DIRto be set with the shell-completion files of the added packages, so you should get tab completion if you use bash completion (IIRC, fish and zsh don't respect XDG_DATA_DIR) related nixpkgs PROtherwise, not much has changed from a nix perspective. Just two renames: