Backport 1.4.2: Refactor service registration (#8976) #9007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* serivceregistration: refactor service registration logic to run later * move state check to the internal func * sr/kubernetes: update setInitialStateInternal godoc * sr/kubernetes: remove return in setInitialState * core/test: fix mockServiceRegistration * address review feedback
tyrannosaurus-becks
approved these changes
May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
serivceregistration: refactor service registration logic to run later
move state check to the internal func
sr/kubernetes: update setInitialStateInternal godoc
sr/kubernetes: remove return in setInitialState
core/test: fix mockServiceRegistration
address review feedback