Skip to content

Conversation

@rculpepper
Copy link
Contributor

This PR is to address the error described in issue #26089 with ed25519 keys

@rculpepper rculpepper requested a review from a team as a code owner May 16, 2024 20:24
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label May 16, 2024
@github-actions
Copy link

github-actions bot commented May 16, 2024

CI Results:
All Go tests succeeded! ✅

@github-actions
Copy link

github-actions bot commented May 16, 2024

Build Results:
All builds succeeded! ✅

Copy link
Contributor

@victorr victorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Is there maybe a unit test we can augment to cover this case?

@stevendpclark
Copy link
Contributor

Unit test would be welcome, there's also a similar error within GetPrivateKeyTypeFromPublicKey.

Would you mind addressing that one as well as part of this? Also what are your thoughts on just adding both the pointer and non-pointer types to all the case statements?

@rculpepper
Copy link
Contributor Author

Also what are your thoughts on just adding both the pointer and non-pointer types to all the case statements?

I don't have a problem with it, but I don't know how useful it would be. I don't see anywhere that we expect an ed25519 key to be a pointer (except the case here)

@@ -0,0 +1,3 @@
```release-note:bug
pki: Fix error in cross-signing using ed25519 keys
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pki: Fix error in cross-signing using ed25519 keys
secrets/pki: Fix error in cross-signing using ed25519 keys

@stevendpclark
Copy link
Contributor

I don't have a problem with it, but I don't know how useful it would be. I don't see anywhere that we expect an ed25519 key to be a pointer (except the case here)

Fair, lets not bother for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-milestone

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants