UI: Dependency bumps 1.17.x #26346
Merged
UI: Dependency bumps 1.17.x #26346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- mout VAULT-25595 VAULT-25603 - follow-redirects VAULT-25605 - terser VAULT-25594 VAULT-25593 - minimatch VAULT-25591 - loader-utils VAULT-25216 VAULT-25590 VAULT-25589 VAULT-25588 VAULT-25587 - decode-uri-component VAULT-25586 - qs VAULT-25585 - @xmldom/xmldom VAULT-25217
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
|
Build Results: |
andaley
approved these changes
Apr 10, 2024
hashishaw
force-pushed
the
ui/dependency-bumps
branch
from
5fc1f1f to
9a73400
Compare
This was referenced Apr 11, 2024
hellobontempo
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a number of outdated upstream dependencies. In order to resolve these, I first deleted
yarn.lockand then re-ranyarn install, which updated the following nested packages to an acceptable version:[email protected][email protected][email protected],5.30.3[email protected],5.1.6,7.4.6,8.0.4,9.0.4[email protected][email protected][email protected],6.12.0@xmldom/[email protected][email protected]Other dependencies needed specific resolutions:
async @ 2.6.4
An old version of
asyncwas required byfireworm, which is only consumed bytestem. We are on the latest version of testem (3.12.0), so the best way to resolve this is to pinasync@^2.6.4which matches the version already imported to the codebase.nth-check @ 2.1.1
An old version of nth-check is a nested dependency of
ember-svg-jarwhich is currently used to display some SVGs that are not available from HDS. I first tried to pin thecss-selectdependency but that caused build errors. Pinningnth-checkdirectly allowed the UI to build, although there were typescript errors that I resolved in the next commitansi-html @ 0.0.8
The requirement for this dependency is
^0.0.7which should have resolved to0.0.8but it seems like yarn doesn't know anything about the package, because when I doyarn info ansi-htmlit has returns with:I pinned it and that seems to resolve and build fine.
ember-template-lint
Lint jobs were failing with a mysterious error on this branch, so I updated
ember-template-lintto 6.0.0 and it was working again. I added the failing lint checks to the template-lintrc file, and will fix the automatic ones in a separate PR so this can be backportedd3 deps
I removed ember-d3 which is unnecessary since we are pulling in the d3 libraries we need. I was able to update all of the d3 libraries we use without issue