Only reload seal config when enable_multiseal is set, or is being disabled #26166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
sgmiller
approved these changes
Mar 26, 2024
|
Build Results: |
|
CI Results: |
victorr
force-pushed
the
victorr/vault-25453-guard-seal-reloading-ce
branch
from
da74ec5 to
0b3df62
Compare
victorr
force-pushed
the
victorr/vault-25453-guard-seal-reloading-ce
branch
from
0b3df62 to
89ce933
Compare
Verify that the in-memory seal generation information is stale and only reload seal configuration when that is the case. When reloading seal configuration, only do it when enable_multiseal is currently set to true, or the new configuration is attempting to set it to true.
victorr
force-pushed
the
victorr/vault-25453-guard-seal-reloading-ce
branch
from
89ce933 to
0d2a62a
Compare
rculpepper
approved these changes
Mar 27, 2024
sgmiller
approved these changes
Mar 27, 2024
Collaborator
sgmiller
left a comment
sgmiller
left a comment
There was a problem hiding this comment.
I can find nothing wrong here. Rachel's comment is worth a thought though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.