Backport of Allow inconsistent filesystem function results for provider configuration into v1.13 #37869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
force-pushed
the
backport/jbardin/provider-eval-scope/unlikely-enough-newt
branch
from
5538bb0 to
41d7ba7
Compare
jbardin
force-pushed
the
backport/jbardin/provider-eval-scope/unlikely-enough-newt
branch
from
c5e0001 to
7d47062
Compare
mildwonkey
approved these changes
Nov 4, 2025
jbardin
deleted the
backport/jbardin/provider-eval-scope/unlikely-enough-newt
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #37854 to be assessed for backporting due to the inclusion of the label 1.13-backport.
The below text is copied from the body of the original PR.
Due to the inherently ephemeral nature of provider configuration, inconsistent function results were tolerated while evaluating provider config. This loophole was found to be used by a number of configurations, which took advantage of it to create the equivalent of ephemeral values before they formally existed in the language.
In order to work around this, we can create a special evaluation scope just for providers, allowing us to override the results check for filesystem functions. I've opted to not further clutter the EvalContext interface since this is intended to be a temporary workaround, and does not contribute to the testing of that interface (the interface is solely for internal unit tests anyway).
Fixes #37792
Overview of commits
eaf225a
4ce205d
4934006