Update with modernize: rangeint and stringsseq

[atombrella]

Terraform Version

The main branch

Use Cases

Just improving the speed of Terraform, updating it with new GoLang features that are faster and more semantic-sugar-like.

Attempted Solutions

I'd open a PR to update the cases of the rangeint matches from modernize I found, but I don't want to spend time on it if it won't receive attention by the maintainers.

Proposal

https://pkg.go.dev/golang.org/x/tools/gopls/internal/analysis/modernize has a list of suggestions to update to use features in newer GoLang versions. Based on a quick search, the rangeint replacement suggestion seems to be slightly faster, and in any case, it looks more GoLang-ish.

rangeint: replace a 3-clause "for i := 0; i < n; i++" loop by "for i := range n", added in go1.22.

There are also cases of this in the code base.

stringsseq: replace Split in "for range strings.Split(...)" by go1.24's more efficient SplitSeq, or Fields with FieldSeq. 

References

No response

[atombrella]

You could mark this good first issue if you accept this proposal :)

[crw]

Hi @atombrella, thanks for raising this request! I'll raise it in triage. One note, IBM is a lot more strict about changing dependencies than was HashiCorp, so there may be additional complications to making these kinds of changes. In any case, we'll discuss and I'll update.

[atombrella]

@crw Nobody said anything adding nor changing dependencies. The link was just meant to show-case patterns that can be updated as you move to newer GoLang versions. You can do this locally, outside of build pipelines etc., and at least the rangeint will be available as a drop-in replacement in VSCode with a simple mouse-click.

[crw]

Thanks for the clarification! That is due to my own ignorance of golang, the devs would likely have known that but thanks for the additional info.