feat(pubsub): Add support for use_table_schema feature in subscription#6881
Merged
modular-magician merged 1 commit intoJan 19, 2024
Conversation
hashicorp#9831) * Remove wait in Pub/Sub Schema tests as server-side changes have been made so that this is not necessary * Add documentation indicating that schema udpates generate revisions that may need to be manually deleted * Remove default_from_api setting for Topic schemaSettings, which is never set with a default from the server * Revert "Remove default_from_api setting for Topic schemaSettings, which is never set with a default from the server" This reverts commit 6163e1669fc328b8433119efa6f953cd4bd972fc. * feat: Add Pub/Sub Subscription support for use_table_schema * feat: Add Pub/Sub Subscription support for use_table_schema * feat: Add Pub/Sub Subscription support for use_table_schema * Apply suggestions from code review Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * Add example of use_table_schema * Add update test for use_table_schema * Fix formatting --------- Co-authored-by: Stephen Lewis (Burrows) <[email protected]> [upstream:20a9ffe2394214386a5e4739ef4f8c635c8289fa] Signed-off-by: Modular Magician <[email protected]>
modular-magician
deleted the
downstream-pr-20a9ffe2394214386a5e4739ef4f8c635c8289fa
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for a new property
use_table_schematogoogle_pubsub_subscriptionRelease Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#9831