Skip to content

Don't send update request if updatemask is empty for resources with terraform_labels field#6443

Merged
modular-magician merged 1 commit into
hashicorp:mainfrom
modular-magician:downstream-pr-c6531043f144daec5952b4af2ccf0ace9d3959b4
Oct 4, 2023
Merged

Don't send update request if updatemask is empty for resources with terraform_labels field#6443
modular-magician merged 1 commit into
hashicorp:mainfrom
modular-magician:downstream-pr-c6531043f144daec5952b4af2ccf0ace9d3959b4

Conversation

@modular-magician

Copy link
Copy Markdown
Collaborator

Fixes hashicorp/terraform-provider-google#16091

If the updateMask is empty, it means that no update is needed. The update request is not needed to be sent.

Release Note Template for Downstream PRs (will be copied)

provider: fixed the bug that update request is sent to services when updateMask is empty

Derived from GoogleCloudPlatform/magic-modules#9154

…erraform_labels field (hashicorp#9154)

* Don't send update request if updatmask is empty when resource has terraform_labels

* Remove the function check field_specific_update_methods

* Set project to billing project for google_network_security_address_group

* Change back of project for resource google_network_security_address_group
[upstream:c6531043f144daec5952b4af2ccf0ace9d3959b4]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician
modular-magician merged commit 6951f37 into hashicorp:main Oct 4, 2023
@modular-magician
modular-magician deleted the downstream-pr-c6531043f144daec5952b4af2ccf0ace9d3959b4 branch November 16, 2024 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error updating {{resource}}: The update_mask in the Update{{resource}}Request must be set

1 participant