Healthcare resource. CORS block is fixed to avoid unnecessary diffs - #5046
Conversation
|
Hi @tombuildsstuff . Could you tell me what I need to do to move this PR forward? |
tombuildsstuff
left a comment
There was a problem hiding this comment.
hey @kutsovmqs
Thanks for this PR - apologies for the delayed review here!
Taking a look through this LGTM - I'll kick off the tests now 👍
Thanks!
|
Running the tests for this and comparing them with master - both are currently failing due to a behavioural change in the API; as such I'm going to merge this for the moment then send a second PR to fix that up - thanks again @kutsovmqs |
|
This has been released in version 1.40.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.40.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
The issue is that default CORS values are create in Azure, even if none are specified in the TF script. If none are specified in the TF script then any TF plan or apply will see that there is a CORS Configuration and want to delete it accordingly, since it's not in the script.