internal/acctest: make domain name generation go-vcr compatible#47786
Merged
internal/acctest: make domain name generation go-vcr compatible#47786
go-vcr compatible#47786Conversation
Successful replay from an acceptance test which previously failed due to missing interactions: ```console % VCR_MODE=REPLAY_ONLY VCR_PATH=/Users/jaredbaker/development/_vcr-testdata/ make t K=fsx T=TestAccFSxWindowsFileSystem_SelfManagedActiveDirectory_passwordWO make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... make: Running acceptance tests on branch: 🌿 tmp3 🌿... TF_ACC=1 go1.26.2 test ./internal/service/fsx/... -v -count 1 -parallel 20 -run='TestAccFSxWindowsFileSystem_SelfManagedActiveDirectory_passwordWO' -timeout 360m -vet=off 2026/05/06 13:29:05 Creating Terraform AWS Provider (SDKv2-style)... 2026/05/06 13:29:05 Initializing Terraform AWS Provider (SDKv2-style)... --- PASS: TestAccFSxWindowsFileSystem_SelfManagedActiveDirectory_passwordWO (15.26s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/fsx 22.714s ```
github-actions
Bot
added
service/arcregionswitch
jar-b
force-pushed
the
td-random-domain-vcr
branch
from
4ba0cc0 to
9516b62
Compare
Contributor
|
Warning This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them. Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rollback Plan
If a change needs to be reverted, we will publish an updated version of the library.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
Description
Swaps out the random string generation functions underpinning
acctest.RandomDomain,acctest.RandomSubdomain, andacctest.RandomFQDomainwhich ago-vcrcompatible equivalent.Successful replay from an acceptance test which previously failed due to missing interactions:
AI Disclosure: This change was generated by AI. All modifications have been reviewed and I fully understand the scope of changes.
Relations
Closes #47769
Relates #25602