Skip to content

r/aws_accessanalyzer_analyzer Fix crash when resource_tags are null #45202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ewbankkit merged 6 commits into from
Nov 21, 2025
Merged

r/aws_accessanalyzer_analyzer Fix crash when resource_tags are null #45202

ewbankkit merged 6 commits into from
Nov 21, 2025

Conversation

@ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Nov 21, 2025 •
edited
Loading

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Additional nil check.

Relations

Closes #45136.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccAccessAnalyzer_serial/Analyzer' PKG=accessanalyzer 
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 b-aws_accessanalyzer_analyzer.resource_tags-crash 🌿...
TF_ACC=1 go1.24.10 test ./internal/service/accessanalyzer/... -v -count 1 -parallel 20  -run=TestAccAccessAnalyzer_serial/Analyzer -timeout 360m -vet=off
2025/11/21 11:24:29 Creating Terraform AWS Provider (SDKv2-style)...
2025/11/21 11:24:29 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccAccessAnalyzer_serial
=== PAUSE TestAccAccessAnalyzer_serial
=== CONT  TestAccAccessAnalyzer_serial
=== RUN   TestAccAccessAnalyzer_serial/Analyzer
=== RUN   TestAccAccessAnalyzer_serial/Analyzer/basic
=== RUN   TestAccAccessAnalyzer_serial/Analyzer/accountInternalAccess
=== RUN   TestAccAccessAnalyzer_serial/Analyzer/accountUnusedAccess
=== RUN   TestAccAccessAnalyzer_serial/Analyzer/disappears
=== RUN   TestAccAccessAnalyzer_serial/Analyzer/tags
=== RUN   TestAccAccessAnalyzer_serial/Analyzer/tags/DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccAccessAnalyzer_serial/Analyzer/tags/EmptyTag_OnUpdate_Add
=== RUN   TestAccAccessAnalyzer_serial/Analyzer/tags/EmptyTag_OnUpdate_Replace
=== RUN   TestAccAccessAnalyzer_serial/Analyzer/tags/DefaultTags_providerOnly
=== RUN   TestAccAccessAnalyzer_serial/Analyzer/tags/DefaultTags_updateToResourceOnly
=== RUN   TestAccAccessAnalyzer_serial/Analyzer/tags/EmptyMap
=== RUN   TestAccAccessAnalyzer_serial/Analyzer/tags/DefaultTags_nonOverlapping
=== RUN   TestAccAccessAnalyzer_serial/Analyzer/tags/DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccAccessAnalyzer_serial/Analyzer/tags/ComputedTag_OnCreate
=== RUN   TestAccAccessAnalyzer_serial/Analyzer/tags/ComputedTag_OnUpdate_Add
=== RUN   TestAccAccessAnalyzer_serial/Analyzer/tags/AddOnUpdate
=== RUN   TestAccAccessAnalyzer_serial/Analyzer/tags/EmptyTag_OnCreate
=== RUN   TestAccAccessAnalyzer_serial/Analyzer/tags/DefaultTags_updateToProviderOnly
=== RUN   TestAccAccessAnalyzer_serial/Analyzer/tags/DefaultTags_emptyResourceTag
=== RUN   TestAccAccessAnalyzer_serial/Analyzer/tags/ComputedTag_OnUpdate_Replace
=== RUN   TestAccAccessAnalyzer_serial/Analyzer/tags/IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccAccessAnalyzer_serial/Analyzer/tags/IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccAccessAnalyzer_serial/Analyzer/tags/basic
=== RUN   TestAccAccessAnalyzer_serial/Analyzer/tags/null
=== RUN   TestAccAccessAnalyzer_serial/Analyzer/tags/DefaultTags_overlapping
=== RUN   TestAccAccessAnalyzer_serial/Analyzer/type_Organization
    analyzer_test.go:88: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccAccessAnalyzer_serial/Analyzer/upgradeV5_95_0
=== RUN   TestAccAccessAnalyzer_serial/Analyzer/organizationInternalAccess
    analyzer_test.go:212: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccAccessAnalyzer_serial/Analyzer/organizationUnusedAccess
    analyzer_test.go:280: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccAccessAnalyzer_serial/Analyzer/nullInResourceTags
--- PASS: TestAccAccessAnalyzer_serial (648.07s)
    --- PASS: TestAccAccessAnalyzer_serial/Analyzer (648.07s)
        --- PASS: TestAccAccessAnalyzer_serial/Analyzer/basic (13.33s)
        --- PASS: TestAccAccessAnalyzer_serial/Analyzer/accountInternalAccess (29.37s)
        --- PASS: TestAccAccessAnalyzer_serial/Analyzer/accountUnusedAccess (12.90s)
        --- PASS: TestAccAccessAnalyzer_serial/Analyzer/disappears (10.75s)
        --- PASS: TestAccAccessAnalyzer_serial/Analyzer/tags (533.21s)
            --- PASS: TestAccAccessAnalyzer_serial/Analyzer/tags/DefaultTags_nullNonOverlappingResourceTag (13.97s)
            --- PASS: TestAccAccessAnalyzer_serial/Analyzer/tags/EmptyTag_OnUpdate_Add (33.55s)
            --- PASS: TestAccAccessAnalyzer_serial/Analyzer/tags/EmptyTag_OnUpdate_Replace (22.60s)
            --- PASS: TestAccAccessAnalyzer_serial/Analyzer/tags/DefaultTags_providerOnly (48.31s)
            --- PASS: TestAccAccessAnalyzer_serial/Analyzer/tags/DefaultTags_updateToResourceOnly (21.76s)
            --- PASS: TestAccAccessAnalyzer_serial/Analyzer/tags/EmptyMap (20.19s)
            --- PASS: TestAccAccessAnalyzer_serial/Analyzer/tags/DefaultTags_nonOverlapping (36.95s)
            --- PASS: TestAccAccessAnalyzer_serial/Analyzer/tags/DefaultTags_nullOverlappingResourceTag (14.14s)
            --- PASS: TestAccAccessAnalyzer_serial/Analyzer/tags/ComputedTag_OnCreate (17.52s)
            --- PASS: TestAccAccessAnalyzer_serial/Analyzer/tags/ComputedTag_OnUpdate_Add (26.15s)
            --- PASS: TestAccAccessAnalyzer_serial/Analyzer/tags/AddOnUpdate (22.48s)
            --- PASS: TestAccAccessAnalyzer_serial/Analyzer/tags/EmptyTag_OnCreate (25.14s)
            --- PASS: TestAccAccessAnalyzer_serial/Analyzer/tags/DefaultTags_updateToProviderOnly (22.74s)
            --- PASS: TestAccAccessAnalyzer_serial/Analyzer/tags/DefaultTags_emptyResourceTag (14.36s)
            --- PASS: TestAccAccessAnalyzer_serial/Analyzer/tags/ComputedTag_OnUpdate_Replace (25.92s)
            --- PASS: TestAccAccessAnalyzer_serial/Analyzer/tags/IgnoreTags_Overlap_DefaultTag (28.83s)
            --- PASS: TestAccAccessAnalyzer_serial/Analyzer/tags/IgnoreTags_Overlap_ResourceTag (33.35s)
            --- PASS: TestAccAccessAnalyzer_serial/Analyzer/tags/basic (47.54s)
            --- PASS: TestAccAccessAnalyzer_serial/Analyzer/tags/null (20.26s)
            --- PASS: TestAccAccessAnalyzer_serial/Analyzer/tags/DefaultTags_overlapping (37.46s)
        --- SKIP: TestAccAccessAnalyzer_serial/Analyzer/type_Organization (0.34s)
        --- PASS: TestAccAccessAnalyzer_serial/Analyzer/upgradeV5_95_0 (43.74s)
        --- SKIP: TestAccAccessAnalyzer_serial/Analyzer/organizationInternalAccess (0.39s)
        --- SKIP: TestAccAccessAnalyzer_serial/Analyzer/organizationUnusedAccess (0.21s)
        --- PASS: TestAccAccessAnalyzer_serial/Analyzer/nullInResourceTags (3.84s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/accessanalyzer	653.293s
% make testacc TESTARGS='-run=TestAccAccessAnalyzer_serial/Analyzer/rganization' PKG=accessanalyzer      
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 b-aws_accessanalyzer_analyzer.resource_tags-crash 🌿...
TF_ACC=1 go1.24.10 test ./internal/service/accessanalyzer/... -v -count 1 -parallel 20  -run=TestAccAccessAnalyzer_serial/Analyzer/rganization -timeout 360m -vet=off
2025/11/21 11:48:46 Creating Terraform AWS Provider (SDKv2-style)...
2025/11/21 11:48:46 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccAccessAnalyzer_serial
=== PAUSE TestAccAccessAnalyzer_serial
=== CONT  TestAccAccessAnalyzer_serial
=== RUN   TestAccAccessAnalyzer_serial/Analyzer
=== RUN   TestAccAccessAnalyzer_serial/Analyzer/organizationInternalAccess
=== RUN   TestAccAccessAnalyzer_serial/Analyzer/type_Organization
=== RUN   TestAccAccessAnalyzer_serial/Analyzer/organizationUnusedAccess
--- PASS: TestAccAccessAnalyzer_serial (69.96s)
    --- PASS: TestAccAccessAnalyzer_serial/Analyzer (69.96s)
        --- PASS: TestAccAccessAnalyzer_serial/Analyzer/organizationInternalAccess (38.66s)
        --- PASS: TestAccAccessAnalyzer_serial/Analyzer/type_Organization (15.22s)
        --- PASS: TestAccAccessAnalyzer_serial/Analyzer/organizationUnusedAccess (16.08s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/accessanalyzer	75.201s

@ewbankkit ewbankkit requested a review from a team as a code owner November 21, 2025 16:42
@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2025

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/accessanalyzer Issues and PRs that pertain to the accessanalyzer service. size/M Managed by automation to categorize the size of a PR. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Nov 21, 2025
@ewbankkit ewbankkit changed the title r/aws accessanalyzer analyzer Fix crash when resource_tags are null r/aws_accessanalyzer_analyzer Fix crash when resource_tags are null Nov 21, 2025
@ewbankkit ewbankkit added the bug Addresses a defect in current functionality. label Nov 21, 2025
johnsonaj
johnsonaj approved these changes Nov 21, 2025
View reviewed changes
Copy link
Member

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ewbankkit ewbankkit merged commit 83fb37e into main Nov 21, 2025
60 checks passed
@ewbankkit ewbankkit deleted the b-aws_accessanalyzer_analyzer.resource_tags-crash branch November 21, 2025 17:27
@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2025

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v6.23.0 milestone Nov 21, 2025
terraform-aws-provider bot pushed a commit that referenced this pull request Nov 21, 2025
Update CHANGELOG.md for #45202
f84529a
@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2025

This functionality has been released in v6.22.1 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnsonaj johnsonaj johnsonaj approved these changes

Assignees

No one assigned

Labels

bug Addresses a defect in current functionality. service/accessanalyzer Issues and PRs that pertain to the accessanalyzer service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Milestone

v6.22.1

Development

Successfully merging this pull request may close these issues.

Provider panic in aws_accessanalyzer_analyzer when resource_tags contains null value

2 participants

@ewbankkit @johnsonaj