Skip to content

Conversation

@akshay2000
Copy link
Contributor

Description

Amazon OpenSearch Service (AOS) now supports dedicated coordinator nodes. This PR adds the support to provision and manage the dedicated coordinator nodes in AOS domains.

Relations

Closes #40135

References

API documentation: https://docs.aws.amazon.com/opensearch-service/latest/APIReference/API_ClusterConfig.html

Output from Acceptance Testing

% make testacc TESTS=TestAccOpenSearchDomain_Cluster_dedicatedCoordinator package=opensearch
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/opensearch/... -v -count 1 -parallel 20 -run='TestAccOpenSearchDomain_Cluster_dedicatedCoordinator'  -timeout 360m
2024/11/19 10:37:54 Initializing Terraform AWS Provider...
=== RUN   TestAccOpenSearchDomain_Cluster_dedicatedCoordinator
=== PAUSE TestAccOpenSearchDomain_Cluster_dedicatedCoordinator
=== CONT  TestAccOpenSearchDomain_Cluster_dedicatedCoordinator
--- PASS: TestAccOpenSearchDomain_Cluster_dedicatedCoordinator (4000.23s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/opensearch 4004.360s

@github-actions
Copy link
Contributor

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/opensearch Issues and PRs that pertain to the opensearch service. needs-triage Waiting for first response or review from a maintainer. labels Nov 19, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @akshay2000 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@akshay2000 akshay2000 marked this pull request as ready for review November 19, 2024 08:30
@akshay2000 akshay2000 requested a review from a team as a code owner November 19, 2024 08:30
@dubesar
Copy link

dubesar commented Nov 19, 2024

LGTM, Approved.

@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 19, 2024
Copy link

@senthpr senthpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. Looks good to me

@Bukhtawar
Copy link

Bukhtawar commented Nov 26, 2024

cc/ @YakDriver @DanielRieske @justinretzolk For help with review.

@skimbrel-figma
Copy link

can we please have some transparency on when we can expect this to be merged and released?

@chrisbrowning
Copy link
Contributor

@akshay2000 I'm also interested in this getting merged but I think you should add the node_options argument to the end user docs for the aws_opensearch_domain resource as part of this PR

@akshay2000
Copy link
Contributor Author

@chrisbrowning Good catch. Updated the PR!

@rabad
Copy link

rabad commented Jan 24, 2025

can we please have some transparency on when we can expect this to be merged and released?

any update?

@breathingdust breathingdust added the partner Contribution from a partner. label Jan 27, 2025
@OdedBaruch
Copy link

Looks goo to me, anyone from hashicorp needs to review and merge it?

@skimbrel-figma
Copy link

can we please get this out?

@ewbankkit ewbankkit self-assigned this Mar 4, 2025
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Mar 4, 2025
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccOpenSearchDomain_basic\|TestAccOpenSearchDomainDataSource_\|TestAccOpenSearchDomain_Cluster_' PKG=opensearch ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/opensearch/... -v -count 1 -parallel 3  -run=TestAccOpenSearchDomain_basic\|TestAccOpenSearchDomainDataSource_\|TestAccOpenSearchDomain_Cluster_ -timeout 720m -vet=off
2025/03/05 08:16:58 Initializing Terraform AWS Provider...
=== RUN   TestAccOpenSearchDomainDataSource_Data_advanced
=== PAUSE TestAccOpenSearchDomainDataSource_Data_advanced
=== RUN   TestAccOpenSearchDomain_basic
=== PAUSE TestAccOpenSearchDomain_basic
=== RUN   TestAccOpenSearchDomain_Cluster_zoneAwareness
=== PAUSE TestAccOpenSearchDomain_Cluster_zoneAwareness
=== RUN   TestAccOpenSearchDomain_Cluster_coldStorage
=== PAUSE TestAccOpenSearchDomain_Cluster_coldStorage
=== RUN   TestAccOpenSearchDomain_Cluster_warm
=== PAUSE TestAccOpenSearchDomain_Cluster_warm
=== RUN   TestAccOpenSearchDomain_Cluster_dedicatedMaster
=== PAUSE TestAccOpenSearchDomain_Cluster_dedicatedMaster
=== RUN   TestAccOpenSearchDomain_Cluster_dedicatedCoordinator
=== PAUSE TestAccOpenSearchDomain_Cluster_dedicatedCoordinator
=== RUN   TestAccOpenSearchDomain_Cluster_update
=== PAUSE TestAccOpenSearchDomain_Cluster_update
=== RUN   TestAccOpenSearchDomain_Cluster_multiAzWithStandbyEnabled
=== PAUSE TestAccOpenSearchDomain_Cluster_multiAzWithStandbyEnabled
=== CONT  TestAccOpenSearchDomainDataSource_Data_advanced
=== CONT  TestAccOpenSearchDomain_Cluster_dedicatedMaster
=== CONT  TestAccOpenSearchDomain_Cluster_coldStorage
--- PASS: TestAccOpenSearchDomainDataSource_basic (1813.63s)
=== CONT  TestAccOpenSearchDomain_Cluster_warm
--- PASS: TestAccOpenSearchDomain_Cluster_coldStorage (2151.32s)
=== CONT  TestAccOpenSearchDomain_Cluster_update
--- PASS: TestAccOpenSearchDomain_Cluster_dedicatedMaster (3213.57s)
=== CONT  TestAccOpenSearchDomain_Cluster_multiAzWithStandbyEnabled
--- PASS: TestAccOpenSearchDomain_Cluster_warm (3932.88s)
=== CONT  TestAccOpenSearchDomain_Cluster_zoneAwareness
--- PASS: TestAccOpenSearchDomain_Cluster_update (2670.35s)
=== CONT  TestAccOpenSearchDomain_Cluster_dedicatedCoordinator
--- PASS: TestAccOpenSearchDomain_Cluster_multiAzWithStandbyEnabled (2540.95s)
=== CONT  TestAccOpenSearchDomain_basic
--- PASS: TestAccOpenSearchDomain_basic (1417.34s)
=== CONT  TestAccOpenSearchDomainDataSource_complex
--- PASS: TestAccOpenSearchDomainDataSource_complex (2033.54s)
--- PASS: TestAccOpenSearchDomain_Cluster_dedicatedCoordinator (4049.49s)
--- PASS: TestAccOpenSearchDomain_Cluster_zoneAwareness (6037.35s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/opensearch	9992.468s

@ewbankkit
Copy link
Contributor

@akshay2000 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 7945bf8 into hashicorp:main Mar 5, 2025
44 checks passed
@akshay2000 akshay2000 deleted the f-aos-dedicated-coordinator-support branch March 6, 2025 03:32
@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement Requests to existing resources that expand the functionality or scope. partner Contribution from a partner. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/opensearch Issues and PRs that pertain to the opensearch service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement]: OpenSearch Coordinator Node Options