-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Added node options support for dedicated coordinator nodes. #40181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added node options support for dedicated coordinator nodes. #40181
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @akshay2000 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
|
LGTM, Approved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes. Looks good to me
|
cc/ @YakDriver @DanielRieske @justinretzolk For help with review. |
|
can we please have some transparency on when we can expect this to be merged and released? |
|
@akshay2000 I'm also interested in this getting merged but I think you should add the |
|
@chrisbrowning Good catch. Updated the PR! |
any update? |
|
Looks goo to me, anyone from hashicorp needs to review and merge it? |
|
can we please get this out? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccOpenSearchDomain_basic\|TestAccOpenSearchDomainDataSource_\|TestAccOpenSearchDomain_Cluster_' PKG=opensearch ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/opensearch/... -v -count 1 -parallel 3 -run=TestAccOpenSearchDomain_basic\|TestAccOpenSearchDomainDataSource_\|TestAccOpenSearchDomain_Cluster_ -timeout 720m -vet=off
2025/03/05 08:16:58 Initializing Terraform AWS Provider...
=== RUN TestAccOpenSearchDomainDataSource_Data_advanced
=== PAUSE TestAccOpenSearchDomainDataSource_Data_advanced
=== RUN TestAccOpenSearchDomain_basic
=== PAUSE TestAccOpenSearchDomain_basic
=== RUN TestAccOpenSearchDomain_Cluster_zoneAwareness
=== PAUSE TestAccOpenSearchDomain_Cluster_zoneAwareness
=== RUN TestAccOpenSearchDomain_Cluster_coldStorage
=== PAUSE TestAccOpenSearchDomain_Cluster_coldStorage
=== RUN TestAccOpenSearchDomain_Cluster_warm
=== PAUSE TestAccOpenSearchDomain_Cluster_warm
=== RUN TestAccOpenSearchDomain_Cluster_dedicatedMaster
=== PAUSE TestAccOpenSearchDomain_Cluster_dedicatedMaster
=== RUN TestAccOpenSearchDomain_Cluster_dedicatedCoordinator
=== PAUSE TestAccOpenSearchDomain_Cluster_dedicatedCoordinator
=== RUN TestAccOpenSearchDomain_Cluster_update
=== PAUSE TestAccOpenSearchDomain_Cluster_update
=== RUN TestAccOpenSearchDomain_Cluster_multiAzWithStandbyEnabled
=== PAUSE TestAccOpenSearchDomain_Cluster_multiAzWithStandbyEnabled
=== CONT TestAccOpenSearchDomainDataSource_Data_advanced
=== CONT TestAccOpenSearchDomain_Cluster_dedicatedMaster
=== CONT TestAccOpenSearchDomain_Cluster_coldStorage
--- PASS: TestAccOpenSearchDomainDataSource_basic (1813.63s)
=== CONT TestAccOpenSearchDomain_Cluster_warm
--- PASS: TestAccOpenSearchDomain_Cluster_coldStorage (2151.32s)
=== CONT TestAccOpenSearchDomain_Cluster_update
--- PASS: TestAccOpenSearchDomain_Cluster_dedicatedMaster (3213.57s)
=== CONT TestAccOpenSearchDomain_Cluster_multiAzWithStandbyEnabled
--- PASS: TestAccOpenSearchDomain_Cluster_warm (3932.88s)
=== CONT TestAccOpenSearchDomain_Cluster_zoneAwareness
--- PASS: TestAccOpenSearchDomain_Cluster_update (2670.35s)
=== CONT TestAccOpenSearchDomain_Cluster_dedicatedCoordinator
--- PASS: TestAccOpenSearchDomain_Cluster_multiAzWithStandbyEnabled (2540.95s)
=== CONT TestAccOpenSearchDomain_basic
--- PASS: TestAccOpenSearchDomain_basic (1417.34s)
=== CONT TestAccOpenSearchDomainDataSource_complex
--- PASS: TestAccOpenSearchDomainDataSource_complex (2033.54s)
--- PASS: TestAccOpenSearchDomain_Cluster_dedicatedCoordinator (4049.49s)
--- PASS: TestAccOpenSearchDomain_Cluster_zoneAwareness (6037.35s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/opensearch 9992.468s|
@akshay2000 Thanks for the contribution 🎉 👏. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Amazon OpenSearch Service (AOS) now supports dedicated coordinator nodes. This PR adds the support to provision and manage the dedicated coordinator nodes in AOS domains.
Relations
Closes #40135
References
API documentation: https://docs.aws.amazon.com/opensearch-service/latest/APIReference/API_ClusterConfig.html
Output from Acceptance Testing