Setting destructive annotation to false, using paths for string concat#143
Merged
gautambaghel merged 7 commits intomainfrom Aug 20, 2025
Merged
Setting destructive annotation to false, using paths for string concat#143gautambaghel merged 7 commits intomainfrom
gautambaghel merged 7 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds the WithDestructiveHintAnnotation(false) to multiple Terraform tools and replaces fmt.Sprintf with path.Join for URL construction to improve path concatenation.
- Adds non-destructive annotations to all read-only Terraform tools to explicitly mark them as safe operations
- Replaces string formatting with proper path joining for URL construction in resource files
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/tools/search_providers.go | Adds destructive hint annotation set to false |
| pkg/tools/search_policies.go | Adds destructive hint annotation set to false |
| pkg/tools/search_modules.go | Adds destructive hint annotation set to false |
| pkg/tools/list_terraform_projects.go | Adds destructive hint annotation set to false |
| pkg/tools/list_terraform_orgs.go | Adds destructive hint annotation set to false |
| pkg/tools/get_provider_details.go | Adds destructive hint annotation set to false |
| pkg/tools/get_policy_details.go | Adds destructive hint annotation set to false |
| pkg/tools/get_module_details.go | Adds destructive hint annotation set to false |
| pkg/tools/get_latest_provider_version.go | Adds destructive hint annotation set to false |
| pkg/tools/get_latest_module_version.go | Adds destructive hint annotation set to false |
| pkg/resources/resources.go | Replaces fmt.Sprintf with path.Join for URL construction |
| pkg/resources/resource_templates.go | Replaces fmt.Sprintf with path.Join for URL construction |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
kartheek-hc
previously approved these changes
Aug 20, 2025
kartheek-hc
previously approved these changes
Aug 20, 2025
kartheek-hc
approved these changes
Aug 20, 2025
|
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PCI review checklist
I have documented a clear reason for, and description of, the change I am making.
If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've documented the impact of any changes to security controls.
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.