Skip to content

Feature/version tools - adding 2 new tools, get latest provider and module versions#122

Merged
gautambaghel merged 3 commits intomainfrom
feature/version-tools
Aug 5, 2025
Merged

Feature/version tools - adding 2 new tools, get latest provider and module versions#122
gautambaghel merged 3 commits intomainfrom
feature/version-tools

Conversation

@gautambaghel
Copy link
Member

@gautambaghel gautambaghel commented Jul 31, 2025

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.

  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.

  • If applicable, I've documented the impact of any changes to security controls.

    Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

@gautambaghel gautambaghel requested a review from a team as a code owner July 31, 2025 20:54
thrashr888
thrashr888 previously approved these changes Aug 1, 2025
Copy link
Member

@thrashr888 thrashr888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, with some nits

}

func getLatestProviderVersionHandler(registryClient *http.Client, request mcp.CallToolRequest, logger *log.Logger) (*mcp.CallToolResult, error) {
namespace, err := request.RequireString("namespace")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when i built mine, i was wondering if we should just default to hashicorp since that would be most often correct if the llm doesn't know it.

i also wonder if we want to lower-case all the input to normalize it. should test for this too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

defaulting to hashicorp stops the model from thinking and ends up calling the tools twice, it's better to add it in the description (saying e.g, hashicorp - which we've done) that way if it has no other choice it uses hashicorp. hashicorp owns <20 providers, we got at least 200 decent providers out there

the APIs are case insensitive, but should be easy to add

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good points. totally agree the description covers it well enough.

@gautambaghel gautambaghel merged commit 1625e6a into main Aug 5, 2025
49 checks passed
@gautambaghel gautambaghel deleted the feature/version-tools branch August 5, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants