Update Telmate/proxmox-api-go#340
Open
Tinyblargon wants to merge 4 commits intohashicorp:mainfrom
Open
Conversation
|
|
|
would be nice to get this merged to fix the issue #328 - can i help somehow? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What code changed, and why?
Hello, Maintainer of Telmate/proxmox-api-go here. Thought I'd help get this project over the context hurdle that was added in 976ef5098918469fca1cf843f96df391264410da.
Added the
context.Contexteverywhere it was missing. Where I didn't know what the right call was I addedcontext.TODO()directly.Refactored the Qemu network interfaces to use the upstream QemuNetworkInterfaces.
Refactored the Qemu PCI devices to use the upstream QemuPciDevices. However there is a problem there. The following properties have not yet been implemented upstream:
mdevromfilelegacy-igdI'm of the understanding these features are rarely used. As someone would have opened a ticket for it otherwise.
For
mdevwe have an issue and it will be fixed.However for
romfileandlegacy-igdwe are unsure how they would fit in our current data structure.Resolved Issues
If your PR resolves any open issue(s), please indicate them like this so they will be closed when your PR is merged:
Related to #339
Rollback Plan
n/a
Changes to Security Controls
n/a