Adds support for resizing cloned disks#324
Open
niwamo wants to merge 1 commit intohashicorp:mainfrom
Open
Conversation
leverages existing features in telmate/proxmox-api-go (which is used for the CloneVM API call) to resize cloned disks IF the type and index fields of a disk entry are used to specify an existing disk
Author
|
@lbajolet-hashicorp it looks like you may be the most active maintainer - if you get a chance to look this over, I'd appreciate it! |
|
time flies... any chance to see this merged one day ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allows (but doesn't require) the user to explicitly set the index of a disk. If set, the plugin will update (not replace) any clone disks in the same slot. The upstream dependency
telmate/proxmox-api-gointelligently resolves the configs and resizes the cloned disk (assuming the new size is greater than the current one). See the call toUpdatehere and the disk-resizing login in the function definition hereResolved Issues
Closes #309
Rollback Plan
If a change needs to be reverted, we will roll out an update to the code within 7 days.
Changes to Security Controls
NA