[Issue 196] feature: datasource to find VM in cluster#295
[Issue 196] feature: datasource to find VM in cluster#295castorsky wants to merge 4 commits intohashicorp:mainfrom
Conversation
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
2599b9a to
155f985
Compare
155f985 to
5740ec7
Compare
mogrogan
left a comment
There was a problem hiding this comment.
Thank you for your solid contribution!
I've left 2 comments but it seems pretty good.
|
In the process of renaming the function and editing the documentation, I noticed two edge cases and fixed them |
Basic configuration verification copied from builder. Template in directory test-fixtures works.
Used anonymous functions instead of a bunch of named ones.
Renamed package and corrected documentation accordingly.
4a177f7 to
c86ee55
Compare
|
@mogrogan Hi, any chances for having this merged and released? |
|
I want to mention this issue from Proxmox Bugzilla: https://bugzilla.proxmox.com/show_bug.cgi?id=6156 |
I have implemented a datasource which was described in #196.
This datasource searches the PVE cluster for some VMs that matches specified filters and returns VM ID for one (and only one) guest. I have chosen such behavior because it will be straightforward for
proxmox-clonebuilder - there will be no need for user to manipulate lists inlocals.I have included some tests and documentation for datasource (but since this is my very first attempt to publish my work for Packer I may have missed something).
This datasource uses undocumented
metafield from Proxmox API responses. (But the Proxmox team recommended using this field to determine guest creation time in the forum messages).Closes #196