Skip to content

Conversation

@cgbaker
Copy link
Contributor

@cgbaker cgbaker commented Jan 5, 2021

stale read support is built-in to RPC forwarding, as long as the request object has IsRead() == true. this PR adds a simple test of that for policy get and list.

IsRead() == true is, like most read requests, provided by the embedded QueryOptions

resolves #7410

@cgbaker cgbaker requested a review from jrasell January 5, 2021 13:46
Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cgbaker cgbaker merged commit 907c7dc into master Jan 5, 2021
@cgbaker cgbaker deleted the 7410-simple-consistency-test branch January 5, 2021 14:01
@github-actions
Copy link

github-actions bot commented Dec 5, 2022

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Scaling] Support stale queries

2 participants