[VAULT-34754] Add a concurrency test to the regexp module #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raskchanky
previously approved these changes
Jun 19, 2025
…exercise MustCompileInterned; fixed a typo in the godoc comment
kubawi
force-pushed
the
kubawi/VAULT-34754/add-a-concurrency-test-to-regexp-package
branch
from
2cd7b54 to
668bc83
Compare
sgmiller
previously approved these changes
Oct 8, 2025
Contributor
sgmiller
left a comment
sgmiller
left a comment
There was a problem hiding this comment.
Do we need the entire license in here since it's in the parent (the whole project?)
Otherwise lgtm
Contributor
Author
Good catch, thanks! Fixed in dfdfa51. |
sgmiller
approved these changes
Oct 17, 2025
raskchanky
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a little test that stresses the new interned regexp library by compiling and accessing the same pattern from a hundred goroutines.
PCI review checklist
If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've worked with GRC to document the impact of any changes to security controls.
Examples of changes to controls include access controls, encryption, logging, etc.
If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.