fix: golangci-lint staticcheck errors #22642

sreeram77 · 2025-08-28T08:23:56Z

Description

fix: golangci-lint staticcheck errors

Testing & Reproduction steps

Links

PR Checklist

updated test coverage
external facing docs updated
appropriate backport labels added
not a security concern

PCI review checklist

I have documented a clear reason for, and description of, the change I am making.
If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've documented the impact of any changes to security controls.

Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

Copilot

Pull Request Overview

This PR fixes golangci-lint staticcheck errors by removing redundant type specifications, simplifying variable declarations, and correcting field accesses to use embedded structs directly rather than accessing them through parent struct fields.

Simplifies variable declarations by removing redundant type specifications where the compiler can infer types
Fixes field access patterns to use embedded struct fields directly instead of through their parent structs
Replaces deprecated string replacement patterns with more efficient alternatives

Reviewed Changes

Copilot reviewed 104 out of 104 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
command/catalog/list/nodes/catalog_list_nodes.go	Removes redundant type specification from variable declaration
command/agent/agent_test.go	Fixes field access to use embedded struct fields directly
agent/xds/*.go	Multiple fixes for embedded struct field access and variable declarations
agent/structs/*.go	Extensive fixes for embedded struct field access patterns
agent/util.go	Improves type assertion handling with type switches
agent/testagent.go	Fixes field access to use embedded struct fields directly
agent/rpcclient/health/*.go	Fixes QueryOptions field access patterns
agent/rpc/peering/service*.go	Fixes Config field access and string replacement patterns
agent/*.go	Various fixes for field access patterns and variable declarations

Comments suppressed due to low confidence (3)

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

agent/grpc-external/limiter/limiter.go

agent/checks/check_test.go

agent/dns.go

* fix: golangci-lint staticcheck errors * fix: missing braces for else in mesh_gateway.go * fix: remove unnecessary type check in otel_sink_test.go

* fix: golangci-lint staticcheck errors (#22642) * fix: golangci-lint staticcheck errors * fix: missing braces for else in mesh_gateway.go * fix: remove unnecessary type check in otel_sink_test.go * fix: golangci-lint issues (#22644) * upgrade: golangci-lint to v2 (#22648) * fix: golangci-lint issues * migrate golangci-lint config to v2 * upgrade: golangci-lint to v2.4.0 * fix: linter issues in agent/consul (#22651) * Fixing bind addr issue, ipv6 bracket, valid peering token issue m go-discover update (#22584) * Fixing bind addr issue, ipv6 bracket and valid peering token issue * Making addr and port compatible with ipv6 * Updating go-discover to v1.1.0 * Updating testcases * chore:added workflow to delete stale branches (#22658) * upgrade: go to v1.25 (#22652) * update: go version to 1.25 * update: gotestsum version * update: mog, buf and deep-copy * fix: add workaround to install covdata in go toolchain * update: regen proto files * fix: install deep-copy with go 1.23 * add: changelog * update: regen deepcopy files * fix: non-constant format string in formatter * upgrade: mockery and proto-gen, and regen files (#22634) * update: mockery to v3 and generate mocks * update: protoc-gen to v1.5.1 and regen proto go files * fix: use InterfaceName_mock.go for filename in mockery * update: generate mock files with mockery v3 * fix: case in structname in mockery config * update: testcase errMsg in TestPatchStruct * update: increase timeout for context in TestSubscribeBackend_IntegrationWithServer_TLSReload --------- Co-authored-by: Sreeram Narayanan <[email protected]> Co-authored-by: P Ajay Rao <[email protected]> Co-authored-by: Vikramarjuna <[email protected]>

hc-github-team-consul-core · 2025-09-08T14:51:16Z

📣 Hi @sreeram77! a backport is missing for this PR [22642] for versions [1.18,1.19,1.20,1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

hc-github-team-consul-core · 2025-09-09T09:14:56Z

📣 Hi @sreeram77! a backport is missing for this PR [22642] for versions [1.18,1.19,1.20,1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

hc-github-team-consul-core · 2025-09-10T09:15:08Z

📣 Hi @sreeram77! a backport is missing for this PR [22642] for versions [1.18,1.19,1.20,1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

hc-github-team-consul-core · 2025-09-11T09:15:06Z

📣 Hi @sreeram77! a backport is missing for this PR [22642] for versions [1.18,1.19,1.20,1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

hc-github-team-consul-core · 2025-09-12T09:15:13Z

📣 Hi @sreeram77! a backport is missing for this PR [22642] for versions [1.18,1.19,1.20,1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

hc-github-team-consul-core · 2025-09-15T09:16:38Z

📣 Hi @sreeram77! a backport is missing for this PR [22642] for versions [1.18,1.20,1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

hc-github-team-consul-core · 2025-10-26T09:23:48Z