Backport of Fix Vault managed intermediate PKI bug into release/1.13.x #15578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/kisunji/vault-managed-inter-pki/neatly-romantic-foxhound
branch
2 times, most recently
from
53f0070 to
2eab893
Compare
github-team-consul-core-pr-approver
approved these changes
Nov 28, 2022
Collaborator
github-team-consul-core-pr-approver
left a comment
github-team-consul-core-pr-approver
left a comment
There was a problem hiding this comment.
Auto approved Consul Bot automated PR
github-actions
bot
added
the
theme/connect
kisunji
approved these changes
Nov 28, 2022
kisunji
deleted the
backport/kisunji/vault-managed-inter-pki/neatly-romantic-foxhound
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #15525 to be assessed for backporting due to the inclusion of the label backport/1.13.
The below text is copied from the body of the original PR.
Description
If you are 1) using Vault as a Consul Connect CA, 2) using Vault-managed policies (i.e. you are bringing external existing Vault mounts to use as CA instead of giving Consul privileges to make mounts itself), and 3) have an empty intermediate PKI mount, Consul will fail to startup the CA Manager.
People have gotten around this issue by adding a dummy cert in the intermediate PKI mount but this PR aims to fix the root cause.
Testing & Reproduction steps
Links
Vault as CA reference: https://developer.hashicorp.com/consul/docs/connect/ca/vault#vault-acl-policies
PR Checklist
Overview of commits