fix: linter issues in agent/consul #22651

sreeram77 · 2025-08-28T13:37:31Z

Description

fix: linter issues in agent/consul

Testing & Reproduction steps

Links

PR Checklist

updated test coverage
external facing docs updated
appropriate backport labels added
not a security concern

PCI review checklist

I have documented a clear reason for, and description of, the change I am making.
If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've documented the impact of any changes to security controls.

Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

Copilot

Pull Request Overview

This PR fixes linter issues in the agent/consul package by removing it from the linters exclusion list and updating the code to comply with various linting rules.

Key Changes

Removed agent/consul from the linters exclusion list in .golangci.yml
Applied various code style improvements including simplifying expressions, removing redundant operations, and using more efficient alternatives
Updated field access patterns to use shorter method chains where appropriate

Reviewed Changes

Copilot reviewed 66 out of 66 changed files in this pull request and generated 5 comments.

File	Description
`.golangci.yml`	Enabled linting for agent/consul package
Multiple `.go` files	Fixed various linter issues including simplifying expressions, improving string operations, and optimizing field access patterns

Comments suppressed due to low confidence (3)

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

agent/consul/acl_endpoint.go

agent/consul/auth/login.go

agent/consul/fsm/decode_downgrade.go

* fix: golangci-lint staticcheck errors (#22642) * fix: golangci-lint staticcheck errors * fix: missing braces for else in mesh_gateway.go * fix: remove unnecessary type check in otel_sink_test.go * fix: golangci-lint issues (#22644) * upgrade: golangci-lint to v2 (#22648) * fix: golangci-lint issues * migrate golangci-lint config to v2 * upgrade: golangci-lint to v2.4.0 * fix: linter issues in agent/consul (#22651) * Fixing bind addr issue, ipv6 bracket, valid peering token issue m go-discover update (#22584) * Fixing bind addr issue, ipv6 bracket and valid peering token issue * Making addr and port compatible with ipv6 * Updating go-discover to v1.1.0 * Updating testcases * chore:added workflow to delete stale branches (#22658) * upgrade: go to v1.25 (#22652) * update: go version to 1.25 * update: gotestsum version * update: mog, buf and deep-copy * fix: add workaround to install covdata in go toolchain * update: regen proto files * fix: install deep-copy with go 1.23 * add: changelog * update: regen deepcopy files * fix: non-constant format string in formatter * upgrade: mockery and proto-gen, and regen files (#22634) * update: mockery to v3 and generate mocks * update: protoc-gen to v1.5.1 and regen proto go files * fix: use InterfaceName_mock.go for filename in mockery * update: generate mock files with mockery v3 * fix: case in structname in mockery config * update: testcase errMsg in TestPatchStruct * update: increase timeout for context in TestSubscribeBackend_IntegrationWithServer_TLSReload --------- Co-authored-by: Sreeram Narayanan <[email protected]> Co-authored-by: P Ajay Rao <[email protected]> Co-authored-by: Vikramarjuna <[email protected]>

hc-github-team-consul-core · 2025-09-08T14:51:14Z

📣 Hi @sreeram77! a backport is missing for this PR [22651] for versions [1.18,1.19,1.20,1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

hc-github-team-consul-core · 2025-09-09T09:14:53Z

📣 Hi @sreeram77! a backport is missing for this PR [22651] for versions [1.18,1.19,1.20,1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

hc-github-team-consul-core · 2025-09-10T09:15:05Z

📣 Hi @sreeram77! a backport is missing for this PR [22651] for versions [1.18,1.19,1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

hc-github-team-consul-core · 2025-09-11T09:15:04Z

📣 Hi @sreeram77! a backport is missing for this PR [22651] for versions [1.18,1.19,1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

hc-github-team-consul-core · 2025-09-12T09:15:11Z

📣 Hi @sreeram77! a backport is missing for this PR [22651] for versions [1.18,1.19,1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

hc-github-team-consul-core · 2025-09-15T09:16:35Z

📣 Hi @sreeram77! a backport is missing for this PR [22651] for versions [1.18,1.19,1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

hc-github-team-consul-core · 2025-09-18T09:16:24Z