Issue 1441 blockquerywait#1443
Merged
Merged
Conversation
The block_query_wait field is a pointer type on the struct. Nil typed fields always need to be checked vs. nil in Merge() functions. I think this was missed as it was put below Once which is of type bool and doesn't need it (ie. followed bad pattern).
Don't use default value in tests that compare values. When outputing test diffs, try harder to output values instead of pointers ints. Fix formatting of config's GoString() output.
findkim
approved these changes
Jan 19, 2021
Contributor
findkim
left a comment
findkim
left a comment
There was a problem hiding this comment.
I like how you added the test first. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue with block_query_wait setting.
Fixes #1441