Allow overriding the default delimiter#1290
Conversation
|
@pearkes anything else needed here? |
|
Hey @mdgreenfield, thanks for the PR. We'll review it and let you know as soon as we can. It shouldn't be to long. |
|
Sorry for the silence on this. Other priorities came up but I'm now making a pass reviewing things. Got to this PR first as it came up for discussion internally. While in general I'm trying to minimize new configuration settings as CT already has a bunch, I'm leaning towards merging this as I think readability is very important. Also making this global makes more sense to me and keeps it simpler than a per-template setting. Anyways, I left a comment with the only change I'd like to see after an initial pass. Thanks. |
133ddef to
a57ae15
Compare
a57ae15 to
1e6ee0d
Compare
|
Thanks @eikenb. I've rebased with master and updated the names of the vars and the config used in the config file. |
For: #1008
This replaces #1081 with a signed CLA.
This implements a defaults section that allows you to overwrite the default delimiters used for all templates.