Skip to content

Allow overriding the default delimiter#1290

Merged
eikenb merged 2 commits into
hashicorp:masterfrom
DataDog:mdgreenfield/default-delimiters
Apr 3, 2020
Merged

Allow overriding the default delimiter#1290
eikenb merged 2 commits into
hashicorp:masterfrom
DataDog:mdgreenfield/default-delimiters

Conversation

@mdgreenfield
Copy link
Copy Markdown
Contributor

For: #1008

This replaces #1081 with a signed CLA.

This implements a defaults section that allows you to overwrite the default delimiters used for all templates.

@mdgreenfield
Copy link
Copy Markdown
Contributor Author

@pearkes anything else needed here?

@eikenb
Copy link
Copy Markdown
Contributor

eikenb commented Oct 18, 2019

Hey @mdgreenfield, thanks for the PR.

We'll review it and let you know as soon as we can. It shouldn't be to long.

Comment thread config/config.go Outdated
@eikenb
Copy link
Copy Markdown
Contributor

eikenb commented Mar 30, 2020

Sorry for the silence on this. Other priorities came up but I'm now making a pass reviewing things. Got to this PR first as it came up for discussion internally.

While in general I'm trying to minimize new configuration settings as CT already has a bunch, I'm leaning towards merging this as I think readability is very important. Also making this global makes more sense to me and keeps it simpler than a per-template setting. Anyways, I left a comment with the only change I'd like to see after an initial pass.

Thanks.

@mdgreenfield mdgreenfield force-pushed the mdgreenfield/default-delimiters branch 8 times, most recently from 133ddef to a57ae15 Compare March 30, 2020 22:58
@mdgreenfield mdgreenfield force-pushed the mdgreenfield/default-delimiters branch from a57ae15 to 1e6ee0d Compare March 30, 2020 22:59
@mdgreenfield
Copy link
Copy Markdown
Contributor Author

Thanks @eikenb. I've rebased with master and updated the names of the vars and the config used in the config file.

@eikenb eikenb added this to the 0.25.0 milestone Mar 30, 2020
@eikenb eikenb merged commit dc274bc into hashicorp:master Apr 3, 2020
@mdgreenfield mdgreenfield deleted the mdgreenfield/default-delimiters branch April 3, 2020 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants