Skip to content

done channel used before initialization #1650

@eikenb

Description

@eikenb

In the new Vault Token Wrapper code it reuses the runner's done channel to know when to close, but only takes the done channel to avoid a circular import issue. But the vault token watcher setup call is before the done channel gets initialized, so it is passed as a nil channel (and thus just always blocks).

Need to move the initialization of the channel above its use.

Note that this will cause gouroutine leaks on config reloads when it starts/stops a new runner.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions