chore: update usage of minio admin library #28
Conversation
| // Get sha256 for request header | ||
| sum := sha256.Sum256(nil) | ||
| req.Header.Set("X-Amz-Content-Sha256", hex.EncodeToString(sum[:])) |
There was a problem hiding this comment.
Do we still need to set the header even though it's nil?
There was a problem hiding this comment.
Yes the minio server still expects the sha to be set correctly even with nil content
elimt
left a comment
elimt
left a comment
There was a problem hiding this comment.
Apart from my minor comment LGTM. I'll leave it to Hugo to validate the minio specific functionality
|
(I wasn't able to try this in actual Boundary -- I got an error when trying to import the plugin: Interesting that go mod didn't seem to follow the I'll test the functionality once this gets merged & tagged |
4 participants
Update's Boundary's usage of the madmin-go library, please note the madmin package created in this PR will be tagged and updated after this is merged, at that point we can update ci to run madmin tests as well.