Implement EIP-2935 Block Hash History #4938
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add ProcessBlockHashHistory function that properly populates the entire history buffer - Fix ProcessParentBlockHash function signature and implementation - Implement correct ring buffer logic for 8192-block history window - Handle transition from old 256-block window to new 8192-block window - Ensure proper parameter ordering and function calls - Fix test compilation issues
- Simplify test to use direct state database creation instead of complex test environment - Remove debug panic statements that were added for troubleshooting - Add proper imports for rawdb and state packages - Ensure test can run without nil pointer dereference errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the EIP-2935 specification to add block hash history window. The enhancement addresses a significant limitation where only recent block hashes were accessible, hindering the development of applications requiring access to older block data. The implementation introduces a new ring buffer storage mechanism that efficiently stores block hashes using modulo-based indexing. When the Prague fork activates, the system automatically populates the entire history buffer with available block hashes, providing seamless access to much older block information. The storage uses a dedicated contract address and maintains backward compatibility while extending the accessible history by 32x.
This enhancement significantly improves functionalities by providing access to historical block states that were previously inaccessible. The implementation follows the EIP-2935 specification exactly, ensuring compatibility with existing tooling and standards while opening new possibilities for blockchain applications that require historical data access.