Merged
Conversation
ShimmerGlass
approved these changes
May 21, 2020
Contributor
|
While we are here shouldn't we rather start checking for version X.*, not >= X.0 ? Not only theoretically major semver version uptick may cause issues but as issue #6 shows it also happens in practice. |
Collaborator
Author
Contributor
|
I mean that I think that we should test if the major version is equal to expected, not equal or greater than. |
Collaborator
Author
|
Got it. @ShimmerGlass what do you think? |
amelhusic
force-pushed
the
feat/version-compare
branch
from
5b057bd to
5caf2fa
Compare
Collaborator
|
I agree with @gdubicki, it's probably better to require a specific major version |
amelhusic
force-pushed
the
feat/version-compare
branch
from
5caf2fa to
03a8805
Compare
Collaborator
Author
|
It makes sense to me too. Updated. |
…urrent program version Fixed regex used to extract program version. `version` arg was unused. Now, it is renamed as `minVer` and used in comparison. Additional `compareVersion` func added to compare minVer with currVer. Comparision with `strings.Compare` didn't worked for cases like `0.1.10 > 0.1.2` and therefore it is removed. Added unit test for `compareVersion` func.
amelhusic
force-pushed
the
feat/version-compare
branch
from
03a8805 to
9d0c478
Compare
ShimmerGlass
approved these changes
May 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.