CLEANUP: environment-check: remove redundant slice#53
Merged
aiharos merged 1 commit intohaproxytech:masterfrom May 26, 2020
Merged
CLEANUP: environment-check: remove redundant slice#53aiharos merged 1 commit intohaproxytech:masterfrom
aiharos merged 1 commit intohaproxytech:masterfrom
Conversation
Collaborator
|
LGTM |
`Find` func accepts slice array and since `out` variable satisfies this, there is no need for additional `[]byte(out)` call.
amelhusic
force-pushed
the
feat/redundant-slice
branch
from
16fbddc to
75fdbb3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Findfunc accepts slice array and sinceoutvariable satisfies this,there is no need for additional
[]byte(out)call.