Conversation
pierresouchay
approved these changes
May 19, 2020
Collaborator
pierresouchay
left a comment
pierresouchay
left a comment
There was a problem hiding this comment.
LGTM, waiting for review on HAProxy side
Addtionnal TLS verification done in SPOE was causing problem as the haproxy fetch methods currently do not provide the full certificate chain. Since TLS verification was already enabled on haproxy side this just removes the additional verification done in SPOE. Fixes: #11
ShimmerGlass
force-pushed
the
delegate-tls
branch
from
fa2a6fe to
9788970
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addtionnal TLS verification done in SPOE was causing problem as the
haproxy fetch methods currently do not provide the full certificate
chain.
Since TLS verification was already enabled on haproxy side this just
removes the additional verification done in SPOE.
Fixes: #11