BUILD/MEDIUM: add haproxy and dataplane binaries to travis#36
Merged
pierresouchay merged 2 commits intohaproxytech:masterfrom Apr 16, 2020
Merged
BUILD/MEDIUM: add haproxy and dataplane binaries to travis#36pierresouchay merged 2 commits intohaproxytech:masterfrom
pierresouchay merged 2 commits intohaproxytech:masterfrom
Conversation
d220b42 to
c95b724
Compare
Collaborator
Author
|
This now allows running unit tests - some of them may need to be tweaked or modified. |
Collaborator
Author
|
Solves #34 |
pierresouchay
requested changes
Apr 16, 2020
Collaborator
pierresouchay
left a comment
There was a problem hiding this comment.
Not working as seen in https://travis-ci.org/github/haproxytech/haproxy-consul-connect/builds/675704444 because haproxy is not in $PATH
--- PASS: TestChangeFrontend (0.00s)
=== RUN TestFromHA
TestFromHA: from_ha_test.go:147: CANNOT Run test because of missing requirement: Failed executing dataplaneapi: exec: already started
--- SKIP: TestFromHA (0.36s)
| install: | ||
| - wget http://www.haproxy.org/download/2.0/src/haproxy-2.0.14.tar.gz | ||
| - tar -zxvf haproxy-2.0.14.tar.gz | ||
| - pushd haproxy-2.0.14 && make TARGET=linux-glibc USE_OPENSSL=1 USE_ZLIB=1 USE_PCRE=1 && sudo make install && popd |
Collaborator
There was a problem hiding this comment.
This is not working as haproxy binary in not in the $PATH
Collaborator
Author
There was a problem hiding this comment.
But the test tries to execute dataplane, and dataplane is already started?
Failed executing dataplaneapi: exec: already started
Haproxy binary is installed with sudo make install into /usr/local/sbin
'haproxy' -> '/usr/local/sbin/haproxy'
'doc/haproxy.1' -> '/usr/local/share/man/man1/haproxy.1'
The path contains /usr/local/sbin
$ export PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.14.2.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.0/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:
Collaborator
Collaborator
Author
There was a problem hiding this comment.
As demonstrated by the latest commit:
$ haproxy -vv
1465HA-Proxy version 2.0.14 2020/04/02 - https://haproxy.org/
1466Build options :
1467 TARGET = linux-glibc
1468 CPU = generic
1469 CC = gcc
1470 CFLAGS = -O2 -g -fno-strict-aliasing -Wdeclaration-after-statement -fwrapv -Wno-unused-label -Wno-sign-compare -Wno-unused-parameter -Wno-old-style-declaration -Wno-ignored-qualifiers -Wno-clobbered -Wno-missing-field-initializers -Wtype-limits
1471 OPTIONS = USE_PCRE=1 USE_OPENSSL=1 USE_ZLIB=1
1472
1473Feature list : +EPOLL -KQUEUE -MY_EPOLL -MY_SPLICE +NETFILTER +PCRE -PCRE_JIT -PCRE2 -PCRE2_JIT +POLL -PRIVATE_CACHE +THREAD -PTHREAD_PSHARED -REGPARM -STATIC_PCRE -STATIC_PCRE2 +TPROXY +LINUX_TPROXY +LINUX_SPLICE +LIBCRYPT +CRYPT_H -VSYSCALL +GETADDRINFO +OPENSSL -LUA +FUTEX +ACCEPT4 -MY_ACCEPT4 +ZLIB -SLZ +CPU_AFFINITY +TFO +NS +DL +RT -DEVICEATLAS -51DEGREES -WURFL -SYSTEMD -OBSOLETE_LINKER +PRCTL +THREAD_DUMP -EVPORTS```
The issue has to be in the tests, either they:
- should not try to start dataplane if it was started already
- stop dataplane as part of each test cleanup
Collaborator
1bbfc39 to
5dfc9a9
Compare
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.