[BUGFIX] Properly detect failure to launch process#21
Merged
aiharos merged 2 commits intohaproxytech:masterfrom Apr 15, 2020
Merged
Conversation
In order to properly detect dataplaneapi/haproxy not launching, cmd.Process != nil needs to be checked as documented in Go APIs.
pierresouchay
force-pushed
the
detect_missing_executables_or_error_launching_program
branch
from
f078623 to
99208a8
Compare
pierresouchay
added a commit
to pierresouchay/haproxy-consul-connect
that referenced
this pull request
Apr 14, 2020
In case where the Process dataplaneapi was not activated for instance the process was hanging forever. Combined with haproxytech#21 it will stop the test immediately if dataplaneapi or haproxy are not in the path
pierresouchay
deleted the
detect_missing_executables_or_error_launching_program
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to properly detect dataplaneapi/haproxy not launching,
cmd.Process != nilneeds to be checked as documented in Go APIs.