Fix piped TBC input with 3D chroma decoders#390
Merged
simoninns merged 2 commits intohappycube:rev7from Dec 30, 2019
Merged
Conversation
These are QByteArrays, so using the fill method won't do the right thing when we're trying to fill with a 16-bit value.
SourceField::loadFields used to load field 1 then fill it with black when it needed a dummy black field. This doesn't work when input is from a pipe (because it would need to seek), so just resize the field data to the right size instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes to SourceField:
Fill dummy fields correctly with black, rather than with a nonsense value; apparently I forgot this was a QByteArray.
Don't load field 1 from the input TBC when creating dummy fields - this meant that piped input didn't work with ntsc3d/transform3d.