Skip to content

feat: Add chaindb option for compaction directory #945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: Add chaindb option for compaction directory #945

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion lib/blockchain/chaindb.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,15 @@ class ChainDB {
this.logger = this.options.logger.context('chaindb');
this.blocks = options.blocks;

if (this.options.compactionDirectory == null) {
this.options.compactionDirectory = this.options.treePrefix + '~';
}

// Allow users to specify a custom compaction directory
if (options.customCompactionDirectory != null) {
this.options.compactionDirectory = options.customCompactionDirectory;
}
Comment on lines +66 to +73
Copy link
Member

@rithvikvibhu rithvikvibhu Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference between compactionDirectory and customCompactionDirectory?

Copy link
Author

@udogri udogri Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

customCompactionDirectory is the user-provided option, while compactionDirectory is what the system actually uses. If the user provides a custom directory, we use that; otherwise, it defaults to treePrefix + '~'.


this.db = bdb.create(this.options);
this.name = 'chain';
this.version = 3;
Expand Down Expand Up @@ -1020,7 +1029,7 @@ class ChainDB {
));
await this.commit();

const tmpDir = this.options.treePrefix + '~';
const tmpDir = this.options.compactionDirectory;

const tmpTree = new Tree({
hash: blake2b,
Expand Down
Loading