Skip to content

Refactor batches #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 23, 2025
Merged

Refactor batches #941

merged 2 commits into from
Jul 23, 2025

Conversation

@nodech
Copy link
Contributor

@nodech nodech commented Jul 14, 2025 •
edited
Loading

Refactor batches in order to allow passing ids optionally and to better track errors on partial failures.

  • Pass objects instead of arrays
  • Accept and track ids in action object
  • Accept option 'allowPartialFailure` for new behaviour.
  • Refactor function a bit

@coveralls
Copy link

coveralls commented Jul 14, 2025 •
edited
Loading

Coverage Status

coverage: 71.642% (-0.03%) from 71.675%
when pulling e11f3bc on nodech:batch-refactor
into b901034 on handshake-org:master.

@nodech nodech added breaking-major Backwards incompatible - Release version wallet part of the codebase labels Jul 16, 2025
@nodech nodech marked this pull request as ready for review July 21, 2025 12:22
@nodech nodech merged commit a812f0b into handshake-org:master Jul 23, 2025
8 checks passed
@nodech nodech deleted the batch-refactor branch August 6, 2025 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

breaking-major Backwards incompatible - Release version wallet part of the codebase

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nodech @coveralls