fix empty paragraphs appearing on block level deletions#31
Open
samik-bind wants to merge 3 commits intohandlewithcarecollective:mainfrom
Open
fix empty paragraphs appearing on block level deletions#31samik-bind wants to merge 3 commits intohandlewithcarecollective:mainfrom
samik-bind wants to merge 3 commits intohandlewithcarecollective:mainfrom
Conversation
Author
|
Easiest way to see this bug is just go to the demo, and delete content from the last paragraph all the way to the start of the list, for example: And with the fix: 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cross-block deletions (e.g. selecting across list items + paragraph and deleting) produced extra empty paragraphs with ZWS insertion marks. This happened because suggestReplaceStep treated purely structural joining slices (empty paragraph tokens with no text) as content to insert.
The fix skips the insertion path when the slice has no text content and there's a deletion range (from !== to), so structural joining tokens are no longer materialized as visible empty paragraphs.