-
-
Notifications
You must be signed in to change notification settings - Fork 10.1k
chore: use rolldown-vite #7489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use rolldown-vite #7489
Conversation
Signed-off-by: Ryan Wang <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7489 +/- ##
============================================
+ Coverage 59.55% 59.64% +0.08%
+ Complexity 3812 3788 -24
============================================
Files 677 676 -1
Lines 23248 23077 -171
Branches 1500 1483 -17
============================================
- Hits 13846 13764 -82
+ Misses 8764 8678 -86
+ Partials 638 635 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Ryan Wang <[email protected]>
@halo-dev/api-client
@halo-dev/components
@halo-dev/richtext-editor
@halo-dev/console-shared
@halo-dev/ui-plugin-bundler-kit
commit: |
Signed-off-by: Ryan Wang <[email protected]>
Signed-off-by: Ryan Wang <[email protected]>
Signed-off-by: Ryan Wang <[email protected]>
Signed-off-by: Ryan Wang <[email protected]>
Signed-off-by: Ryan Wang <[email protected]>
|
Right now, the only thing left is the polyfills issue. Unfortunately, we can’t use @vitejs/plugin-legacy directly at the moment, since it looks like rolldown doesn’t support building in the system format yet. |
Signed-off-by: Ryan Wang <[email protected]>
Signed-off-by: Ryan Wang <[email protected]>
Signed-off-by: Ryan Wang <[email protected]>
Signed-off-by: Ryan Wang <[email protected]>
Signed-off-by: Ryan Wang <[email protected]>
Signed-off-by: Ryan Wang <[email protected]>
Signed-off-by: Ryan Wang <[email protected]>
|
@ruibaby Unfortunately legacy output is not support yet (according to the PR). Not aware of any workaround at the moment |
Thank you for mentioning this. I will follow up on this PR. |
Signed-off-by: Ryan Wang <[email protected]>
Signed-off-by: Ryan Wang <[email protected]>
Signed-off-by: Ryan Wang <[email protected]>
Signed-off-by: Ryan Wang <[email protected]>
Signed-off-by: Ryan Wang <[email protected]>
|
JohnNiang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |



What type of PR is this?
/area ui
/kind improvement
What this PR does / why we need it:
Using rolldown-vite to improve the build speed of the UI project, but some features are still not supported and need to wait.
before:
after:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?