Skip to content

Conversation

@ruibaby
Copy link
Member

@ruibaby ruibaby commented May 31, 2025

What type of PR is this?

/area ui
/kind improvement

What this PR does / why we need it:

Using rolldown-vite to improve the build speed of the UI project, but some features are still not supported and need to wait.

before:

image

after:

image

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Signed-off-by: Ryan Wang <[email protected]>
@f2c-ci-robot f2c-ci-robot bot added area/ui Issues or PRs related to the Halo UI do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/improvement Categorizes issue or PR as related to a improvement. labels May 31, 2025
@f2c-ci-robot f2c-ci-robot bot requested review from LIlGG and guqing May 31, 2025 01:42
@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label May 31, 2025
@codecov
Copy link

codecov bot commented May 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.64%. Comparing base (42c374d) to head (7a974dc).
Report is 77 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7489      +/-   ##
============================================
+ Coverage     59.55%   59.64%   +0.08%     
+ Complexity     3812     3788      -24     
============================================
  Files           677      676       -1     
  Lines         23248    23077     -171     
  Branches       1500     1483      -17     
============================================
- Hits          13846    13764      -82     
+ Misses         8764     8678      -86     
+ Partials        638      635       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Ryan Wang <[email protected]>
@pkg-pr-new
Copy link

pkg-pr-new bot commented May 31, 2025

Open in StackBlitz

@halo-dev/api-client

npm i https://pkg.pr.new/@halo-dev/api-client@7489

@halo-dev/components

npm i https://pkg.pr.new/@halo-dev/components@7489

@halo-dev/richtext-editor

npm i https://pkg.pr.new/@halo-dev/richtext-editor@7489

@halo-dev/console-shared

npm i https://pkg.pr.new/@halo-dev/console-shared@7489

@halo-dev/ui-plugin-bundler-kit

npm i https://pkg.pr.new/@halo-dev/ui-plugin-bundler-kit@7489

commit: 7a974dc

@ruibaby
Copy link
Member Author

ruibaby commented Jun 2, 2025

Hi @TheAlexLichter

Right now, the only thing left is the polyfills issue. Unfortunately, we can’t use @vitejs/plugin-legacy directly at the moment, since it looks like rolldown doesn’t support building in the system format yet.
Do you have any suggestions or maybe a temporary workaround for this? Thanks a lot!

ruibaby added 7 commits June 2, 2025 15:33
Signed-off-by: Ryan Wang <[email protected]>
Signed-off-by: Ryan Wang <[email protected]>
Signed-off-by: Ryan Wang <[email protected]>
Signed-off-by: Ryan Wang <[email protected]>
Signed-off-by: Ryan Wang <[email protected]>
Signed-off-by: Ryan Wang <[email protected]>
@TheAlexLichter
Copy link

@ruibaby Unfortunately legacy output is not support yet (according to the PR). Not aware of any workaround at the moment

@ruibaby
Copy link
Member Author

ruibaby commented Jun 3, 2025

@ruibaby Unfortunately legacy output is not support yet (according to the PR). Not aware of any workaround at the moment

Thank you for mentioning this. I will follow up on this PR.

Signed-off-by: Ryan Wang <[email protected]>
@f2c-ci-robot f2c-ci-robot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 6, 2025
@f2c-ci-robot f2c-ci-robot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 6, 2025
@f2c-ci-robot f2c-ci-robot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 13, 2025
@f2c-ci-robot f2c-ci-robot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 16, 2025
@f2c-ci-robot f2c-ci-robot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 18, 2025
@f2c-ci-robot f2c-ci-robot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 19, 2025
@ruibaby ruibaby changed the title WIP: chore: use rolldown-vite chore: use rolldown-vite Jun 19, 2025
@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 19, 2025
ruibaby added 2 commits June 19, 2025 22:05
Signed-off-by: Ryan Wang <[email protected]>
Signed-off-by: Ryan Wang <[email protected]>
@sonarqubecloud
Copy link

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2025
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jun 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2025
@f2c-ci-robot f2c-ci-robot bot merged commit 7b25791 into halo-dev:main Jun 19, 2025
11 checks passed
@ruibaby ruibaby deleted the rolldown-vite branch June 24, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants