Skip to content

Correct GH edit address#532

Merged
hahwul merged 2 commits intohahwul:devfrom
palmiak:patch-1
Feb 21, 2024
Merged

Correct GH edit address#532
hahwul merged 2 commits intohahwul:devfrom
palmiak:patch-1

Conversation

@palmiak
Copy link
Contributor

@palmiak palmiak commented Feb 20, 2024

I saw that the "improve the page button" leads to 404.

It's because the git_edit_address is https://github.com/hahwul/dalfox/docs when it should be https://github.com/hahwul/dalfox/tree/main/docs.

This should fix the problem

hahwul and others added 2 commits February 16, 2024 00:32
I saw that the "improve the page button" leads to 404.

It's because the git_edit_address is `https://github.com/hahwul/dalfox/docs` when it should be `https://github.com/hahwul/dalfox/tree/main/docs`.

This should fix the problem
@hahwul hahwul self-assigned this Feb 21, 2024
Copy link
Owner

@hahwul hahwul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool 👍

@hahwul hahwul added the documentation Improvements or additions to documentation label Feb 21, 2024
@hahwul hahwul changed the base branch from main to dev February 21, 2024 15:00
@hahwul
Copy link
Owner

hahwul commented Feb 21, 2024

Hi @palmiak
Thank you so much for taking the time to report the issue and for sending us a PR! Your effort really helps dalfox improve. I'm super grateful for your contribution :D

@hahwul hahwul merged commit 7031674 into hahwul:dev Feb 21, 2024
@palmiak
Copy link
Contributor Author

palmiak commented Feb 21, 2024

Happy to help ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants