This repository was archived by the owner on May 15, 2024. It is now read-only.
Open
Conversation
The non-ordinal comparison caused file entries with an emoji name to be treated as directories.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #218.
The non-ordinal comparison caused file entries with an emoji name to be treated as directories.
DotNetZip treats an entry as a directory if its name ends with
"/". This is checked usingstring.EndsWith(string). That's an issue becausestring.EndsWith(string)uses the currentCultureInfoto check for the suffix. For all cultures I've tested (includingCultureInfo.InvariantCulture), the following was true:\u26BEis the Unicode escape sequence for the character ⚾ (U+26BE BASEBALL), which is somehow ignored bystring.EndsWith(string). Other emoji characters are also affected by this, but not all emoji. I've yet to see a pattern here.Using the overload
string.EndsWith(string, StringComparison)withStringComparison.Ordinalfixes this issue.I've also fixed other calls to
string.EndsWith(string)as well asstring.StartsWith(string)(which exposes the same behavior with strings beginning with some emoji characters), which are not strictly related to #218, but are probably problematic as well.