Skip to content
This repository was archived by the owner on May 15, 2024. It is now read-only.

Ignore duplicates 2#180

Open
uecasm wants to merge 2 commits intohaf:masterfrom
uecasm:ignore-duplicates2
Open

Ignore duplicates 2#180
uecasm wants to merge 2 commits intohaf:masterfrom
uecasm:ignore-duplicates2

Conversation

@uecasm
Copy link

@uecasm uecasm commented Sep 27, 2019

Fixes another case where duplicated files in externally-created zips could cause an exception on read.

zf._entries.Add(e.FileName,e);
if (!zf._entriesInsensitive.ContainsKey(e.FileName))
zf._entriesInsensitive.Add(e.FileName,e);
if (!(zf.IgnoreDuplicateFiles && zf._entries.ContainsKey(e.FileName)))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could use the private _IgnoreDuplicateFiles here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants